string problems

[salex319]

Running MikroPascal PRO for PIC 6.6.3

I had to change the following line:

Code: Select all

 ostr:='$'+strOurNodeID+'9'+chr(Seq)+'10'+MakeReply+#13;

to:

Code: Select all

             ostr:=MakeReply;
             ostr:='$'+strOurNodeID+'9'+chr(Seq)+'10'+ostr+#13;

to produce the correct output. Before the change the function simply left out the result from the MakeReply function.

I also had to add the #0 to the end of the following line to get the string properly terminated.

Code: Select all

              RplyStr:=RplyStr + DEVTYPE + VERSION + HWCONFIG + #0;

These are bugs I believe or am I mistaken.

[janni]

These are bugs I believe or am I mistaken.

The second one certainly is and persists since at least v. 6.40 of mP PRO .

The first one may be a limitation rather than a bug - depending on the way the function was defined. Still, it's true that concatenating strings with the '+' operator is not well implemented and it's safer to use functions like strcat for this purpose.

[lana.arsic]

Hi,

Can you please attach your project in a zip/rar archive, so I could test it?

Best regards,
Lana

[salex319]

Thanks for the offer to investigate. I don't have the exact code configuration that exhibited the issue and I don't have the time to go back and try to reproduce it. I will be more careful to save the code next time I see this. Thank you.

[lana.arsic]

Hi,

You're welcome. If that issue occurs again,
please send whole code at support[att]mikroe[dot]com.

Best regards,
Lana