Combining 8 bit integers to 32 bit long integer

[dariods]

I have split a 32 bit long integer to 8 bits and saved to 4 locations on the EEPROM. The For loop code doesn't work, there seems to be problem with "Distance |=" but I do not know how to solve it. Please guide

Code: Select all

// PIC16F886
void read_saved_odo(){
   unsigned long int Distance = 12345678;
   unsigned int i;
   unsigned int j = 11;   
  
   
    // this does not work
    for(i = 3; i = 0; i--){
    Distance |= (unsigned long int)((EEPROM_Read(j)) << (i * 8));
    j--;
     } 
}

[michig54]

Why are you initializing Distance to 12345678? The |= will or any values read from the eeprom with this value. You should probably initialize it to 0, unless this is your intention.

[paulfjujo]

hello,

where do you store data in eeprom ; wich adresse ..?
we can suppose start adresse is 11 ?
remark: a pair adresse is always better ...;

Code: Select all

 unsigned char *p1;

 p1=&Distance;
 for(i = 0; i<3; i++)
 {
   *(p1+i)=EEPROM_Read(j+i);
 }

but not checked !!!